Manual cleanup of the remaining set([…]) and set((…)).

.gitlab-ci.yml

@@ -1,8 +0,0 @@
-test:
-  tags:
-    - docker
-  image: ubuntu:latest
-  script:
-    - apt update
-    - apt install -y python3 cython3
-    - ./run_tests.py

examples/http_over_xmpp.py

@@ -13,7 +13,7 @@
 
 from slixmpp import ClientXMPP
 
-from argparse import ArgumentParser
+from optparse import OptionParser
 import logging
 import getpass
 
@@ -58,40 +58,40 @@ if __name__ == '__main__':
     # ./http_over_xmpp.py -J <jid> -P <pwd> -i <ip> -p <port> [-v]
     #
 
-    parser = ArgumentParser()
+    parser = OptionParser()
 
     # Output verbosity options.
-    parser.add_argument(
+    parser.add_option(
         '-v', '--verbose', help='set logging to DEBUG', action='store_const',
         dest='loglevel', const=logging.DEBUG, default=logging.ERROR
     )
 
     # JID and password options.
-    parser.add_argument('-J', '--jid', dest='jid', help='JID')
-    parser.add_argument('-P', '--password', dest='password', help='Password')
+    parser.add_option('-J', '--jid', dest='jid', help='JID')
+    parser.add_option('-P', '--password', dest='password', help='Password')
 
     # XMPP server ip and port options.
-    parser.add_argument(
+    parser.add_option(
         '-i', '--ipaddr', dest='ipaddr',
         help='IP Address of the XMPP server', default=None
     )
-    parser.add_argument(
+    parser.add_option(
         '-p', '--port', dest='port',
         help='Port of the XMPP server', default=None
     )
 
-    args = parser.parse_args()
+    opts, args = parser.parse_args()
 
     # Setup logging.
-    logging.basicConfig(level=args.loglevel,
+    logging.basicConfig(level=opts.loglevel,
                         format='%(levelname)-8s %(message)s')
 
-    if args.jid is None:
-        args.jid = input('Username: ')
-    if args.password is None:
-        args.password = getpass.getpass('Password: ')
+    if opts.jid is None:
+        opts.jid = input('Username: ')
+    if opts.password is None:
+        opts.password = getpass.getpass('Password: ')
 
-    xmpp = HTTPOverXMPPClient(args.jid, args.password)
+    xmpp = HTTPOverXMPPClient(opts.jid, opts.password)
     xmpp.connect()
     xmpp.process()
 

setup.py

@@ -9,7 +9,7 @@
 
 import os
 from pathlib import Path
-from subprocess import call, DEVNULL, check_output, CalledProcessError
+from subprocess import call, DEVNULL
 from tempfile import TemporaryFile
 try:
     from setuptools import setup
@@ -35,31 +35,18 @@ CLASSIFIERS = [
 
 packages = [str(mod.parent) for mod in Path('slixmpp').rglob('__init__.py')]
 
-def check_include(library_name, header):
-    command = [os.environ.get('PKG_CONFIG', 'pkg-config'), '--cflags', library_name]
-    try:
-        cflags = check_output(command).decode('utf-8').split()
-    except FileNotFoundError:
-        print('pkg-config not found.')
-        return False
-    except CalledProcessError:
-        # pkg-config already prints the missing libraries on stderr.
-        return False
-    command = [os.environ.get('CC', 'cc')] + cflags + ['-E', '-']
+def check_include(header):
+    command = [os.environ.get('CC', 'cc'), '-E', '-']
     with TemporaryFile('w+') as c_file:
         c_file.write('#include <%s>' % header)
         c_file.seek(0)
         try:
             return call(command, stdin=c_file, stdout=DEVNULL, stderr=DEVNULL) == 0
         except FileNotFoundError:
-            print('%s headers not found.' % library_name)
             return False
 
-HAS_PYTHON_HEADERS = check_include('python3', 'Python.h')
-HAS_STRINGPREP_HEADERS = check_include('libidn', 'stringprep.h')
-
 ext_modules = None
-if HAS_PYTHON_HEADERS and HAS_STRINGPREP_HEADERS:
+if check_include('stringprep.h'):
     try:
         from Cython.Build import cythonize
     except ImportError:
@@ -67,7 +54,7 @@ if HAS_PYTHON_HEADERS and HAS_STRINGPREP_HEADERS:
     else:
         ext_modules = cythonize('slixmpp/stringprep.pyx')
 else:
-    print('Falling back to the slow stringprep module.')
+    print('libidn-dev not found, falling back to the slow stringprep module.')
 
 setup(
     name="slixmpp",

slixmpp/clientxmpp.py

@@ -15,7 +15,6 @@
 import asyncio
 import logging
 
-from slixmpp.jid import JID
 from slixmpp.stanza import StreamFeatures
 from slixmpp.basexmpp import BaseXMPP
 from slixmpp.exceptions import XMPPError
@@ -109,21 +108,10 @@ class ClientXMPP(BaseXMPP):
                 CoroutineCallback('Stream Features',
                      MatchXPath('{%s}features' % self.stream_ns),
                      self._handle_stream_features))
-        def roster_push_filter(iq):
-            from_ = iq['from']
-            if from_ and from_ != JID('') and from_ != self.boundjid.bare:
-                reply = iq.reply()
-                reply['type'] = 'error'
-                reply['error']['type'] = 'cancel'
-                reply['error']['code'] = 503
-                reply['error']['condition'] = 'service-unavailable'
-                reply.send()
-                return
-            self.event('roster_update', iq)
         self.register_handler(
                 Callback('Roster Update',
                          StanzaPath('iq@type=set/roster'),
-                         roster_push_filter))
+                         lambda iq: self.event('roster_update', iq)))
 
         # Setup default stream features
         self.register_plugin('feature_starttls')

slixmpp/plugins/xep_0009/rpc.py

@@ -121,7 +121,7 @@ class XEP_0009(BasePlugin):
     def _recipient_unvailable(self, iq):
         payload = iq.get_payload()
         iq = iq.reply()
-        iq.error().set_payload(payload)
+        error().set_payload(payload)
         iq['error']['code'] = '404'
         iq['error']['type'] = 'wait'
         iq['error']['condition'] = 'recipient-unavailable'

slixmpp/plugins/xep_0079/stanza.py

@@ -8,7 +8,6 @@
 
 from __future__ import unicode_literals
 
-from slixmpp import JID
 from slixmpp.xmlstream import ElementBase, register_stanza_plugin
 
 

slixmpp/plugins/xep_0221/stanza.py

@@ -36,7 +36,7 @@ class URI(ElementBase):
         self.xml.text = value
 
     def del_value(self):
-        self.xml.text = ''
+        sel.xml.text = ''
 
 
 register_stanza_plugin(Media, URI, iterable=True)

slixmpp/plugins/xep_0222.py

@@ -28,7 +28,7 @@ class XEP_0222(BasePlugin):
     profile = {'pubsub#persist_items': True,
                'pubsub#send_last_published_item': 'never'}
 
-    def configure(self, node, ifrom=None, callback=None, timeout=None):
+    def configure(self, node):
         """
         Update a node's configuration to match the public storage profile.
         """

slixmpp/plugins/xep_0223.py

@@ -28,7 +28,7 @@ class XEP_0223(BasePlugin):
     profile = {'pubsub#persist_items': True,
                'pubsub#send_last_published_item': 'never'}
 
-    def configure(self, node, ifrom=None, callback=None, timeout=None):
+    def configure(self, node):
         """
         Update a node's configuration to match the public storage profile.
         """

slixmpp/plugins/xep_0258/stanza.py

@@ -8,7 +8,6 @@
 
 from base64 import b64encode, b64decode
 
-from slixmpp import JID
 from slixmpp.util import bytes
 from slixmpp.xmlstream import ElementBase, ET, register_stanza_plugin
 

slixmpp/plugins/xep_0313/stanza.py

@@ -135,5 +135,5 @@ class Archived(ElementBase):
     def get_by(self):
         return JID(self._get_attr('by'))
 
-    def set_by(self, value):
+    def set_by(self):
         return self._set_attr('by', str(value))

slixmpp/plugins/xep_0323/stanza/sensordata.py

@@ -10,7 +10,7 @@
 
 from slixmpp import Iq, Message
 from slixmpp.xmlstream import register_stanza_plugin, ElementBase, ET, JID
-import re
+from re import match
 
 class Sensordata(ElementBase):
     """ Placeholder for the namespace, not used as a stanza """

slixmpp/plugins/xep_0333/hints.py

@@ -11,8 +11,6 @@ import logging
 from slixmpp import Message
 from slixmpp.plugins import BasePlugin
 from slixmpp.xmlstream import register_stanza_plugin
-from slixmpp.xmlstream.handler import Callback
-from slixmpp.xmlstream.matcher import StanzaPath
 from slixmpp.plugins.xep_0333 import stanza, Markable, Received, Displayed, Acknowledged
 
 log = logging.getLogger(__name__)

slixmpp/plugins/xep_0380/__init__.py

@@ -1,15 +0,0 @@
-"""
-    Slixmpp: The Slick XMPP Library
-    Copyright (C) 2016 Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
-    This file is part of Slixmpp.
-
-    See the file LICENSE for copying permission.
-"""
-
-from slixmpp.plugins.base import register_plugin
-
-from slixmpp.plugins.xep_0380.stanza import Encryption
-from slixmpp.plugins.xep_0380.eme import XEP_0380
-
-
-register_plugin(XEP_0380)

slixmpp/plugins/xep_0380/eme.py

@@ -1,69 +0,0 @@
-"""
-    Slixmpp: The Slick XMPP Library
-    Copyright (C) 2016 Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
-    This file is part of Slixmpp.
-
-    See the file LICENSE for copying permission.
-"""
-
-import logging
-
-import slixmpp
-from slixmpp.stanza import Message
-from slixmpp.xmlstream.handler import Callback
-from slixmpp.xmlstream.matcher import StanzaPath
-from slixmpp.xmlstream import register_stanza_plugin, ElementBase, ET
-from slixmpp.plugins import BasePlugin
-from slixmpp.plugins.xep_0380 import stanza, Encryption
-
-
-log = logging.getLogger(__name__)
-
-
-class XEP_0380(BasePlugin):
-
-    """
-    XEP-0380: Explicit Message Encryption
-    """
-
-    name = 'xep_0380'
-    description = 'XEP-0380: Explicit Message Encryption'
-    dependencies = {'xep_0030'}
-    default_config = {
-        'template': 'This message is encrypted with {name} ({namespace})',
-    }
-
-    mechanisms = {
-        'jabber:x:encrypted': 'Legacy OpenPGP',
-        'urn:xmpp:ox:0': 'OpenPGP for XMPP',
-        'urn:xmpp:otr:0': 'OTR',
-        'eu.siacs.conversations.axolotl': 'Legacy OMEMO',
-        'urn:xmpp:omemo:0': 'OMEMO',
-    }
-
-    def plugin_init(self):
-        self.xmpp.register_handler(
-            Callback('Explicit Message Encryption',
-                     StanzaPath('message/eme'),
-                     self._handle_eme))
-
-        register_stanza_plugin(Message, Encryption)
-
-    def plugin_end(self):
-        self.xmpp.remove_handler('Chat State')
-
-    def session_bind(self, jid):
-        self.xmpp.plugin['xep_0030'].add_feature(Encryption.namespace)
-
-    def has_eme(self, msg):
-        return msg.xml.find('{%s}encryption' % Encryption.namespace) is not None
-
-    def replace_body_with_eme(self, msg):
-        eme = msg['eme']
-        namespace = eme['namespace']
-        name = self.mechanisms[namespace] if namespace in self.mechanisms else eme['name']
-        body = self.config['template'].format(name=name, namespace=namespace)
-        msg['body'] = body
-
-    def _handle_eme(self, msg):
-        self.xmpp.event('message_encryption', msg)

slixmpp/plugins/xep_0380/stanza.py

@@ -1,16 +0,0 @@
-"""
-    Slixmpp: The Slick XMPP Library
-    Copyright (C) 2016 Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
-    This file is part of Slixmpp.
-
-    See the file LICENSE for copying permission.
-"""
-
-from slixmpp.xmlstream import ElementBase
-
-
-class Encryption(ElementBase):
-    name = 'encryption'
-    namespace = 'urn:xmpp:eme:0'
-    plugin_attrib = 'eme'
-    interfaces = {'namespace', 'name'}

slixmpp/stanza/message.py

@@ -48,7 +48,7 @@ class Message(RootStanza):
     namespace = 'jabber:client'
     plugin_attrib = name
     interfaces = {'type', 'to', 'from', 'id', 'body', 'subject', 'thread',
-                  'parent_thread', 'mucroom', 'mucnick'}
+                  'parent_thread', 'mucroom', 'mucnick'])
     sub_interfaces = {'body', 'subject', 'thread'}
     lang_interfaces = sub_interfaces
     types = {'normal', 'chat', 'headline', 'error', 'groupchat'}

slixmpp/util/sasl/client.py

@@ -75,7 +75,7 @@ def sasl_mech(score):
             MECH_SEC_SCORES[mech.name] = mech.score
             if mech.channel_binding:
                 MECHANISMS[mech.name + '-PLUS'] = mech
-                MECH_SEC_SCORES[mech.name] = mech.score + 10
+                MECH_SEC_SCORES[name] = mech.score + 10
         return mech
     return register
 

slixmpp/util/stringprep_profiles.py

@@ -146,7 +146,6 @@ def create(nfkc=True, bidi=True, mappings=None,
         if bidi:
             check_bidi(data)
         if query and unassigned:
-            #check_unassigned(data, unassigned)
-            raise StringPrepError('Query profile with unassigned data is unimplemented.')
+            check_unassigned(data, unassigned)
         return data
     return profile

slixmpp/version.py

@@ -9,5 +9,5 @@
 # We don't want to have to import the entire library
 # just to get the version info for setup.py
 
-__version__ = '1.2.3'
-__version_info__ = (1, 2, 3)
+__version__ = '1.2.1'
+__version_info__ = (1, 2, 1)

slixmpp/xmlstream/cert.py

@@ -76,7 +76,7 @@ def extract_names(raw_cert):
             name_type = name.getName()
             if name_type == 'dNSName':
                 results['DNS'].add(decode_str(name.getComponent()))
-            elif name_type == 'uniformResourceIdentifier':
+            if name_type == 'uniformResourceIdentifier':
                 value = decode_str(name.getComponent())
                 if value.startswith('xmpp:'):
                     results['URI'].add(value[5:])

slixmpp/xmlstream/xmlstream.py

@@ -19,7 +19,7 @@ import ssl
 import weakref
 import uuid
 
-import xml.etree.ElementTree as ET
+import xml.etree.ElementTree
 
 from slixmpp.xmlstream.asyncio import asyncio
 from slixmpp.xmlstream import tostring, highlight
@@ -339,7 +339,7 @@ class XMLStream(asyncio.BaseProtocol):
         """
         self.xml_depth = 0
         self.xml_root = None
-        self.parser = ET.XMLPullParser(("start", "end"))
+        self.parser = xml.etree.ElementTree.XMLPullParser(("start", "end"))
 
     def connection_made(self, transport):
         """Called when the TCP connection has been established with the server
@@ -359,46 +359,32 @@ class XMLStream(asyncio.BaseProtocol):
         the stream is opened, etc).
         """
         self.parser.feed(data)
-        try:
-            for event, xml in self.parser.read_events():
-                if event == 'start':
-                    if self.xml_depth == 0:
-                        # We have received the start of the root element.
-                        self.xml_root = xml
-                        log.debug('RECV: %s',
-                                  highlight(tostring(self.xml_root,
-                                                     xmlns=self.default_ns,
-                                                     stream=self,
-                                                     top_level=True,
-                                                     open_only=True)))
-                        self.start_stream_handler(self.xml_root)
-                    self.xml_depth += 1
-                if event == 'end':
-                    self.xml_depth -= 1
-                    if self.xml_depth == 0:
-                        # The stream's root element has closed,
-                        # terminating the stream.
-                        log.debug("End of stream received")
-                        self.abort()
-                    elif self.xml_depth == 1:
-                        # A stanza is an XML element that is a direct child of
-                        # the root element, hence the check of depth == 1
-                        self._spawn_event(xml)
-                        if self.xml_root is not None:
-                            # Keep the root element empty of children to
-                            # save on memory use.
-                            self.xml_root.clear()
-        except ET.ParseError:
-            log.error('Parse error: %r', data)
-
-            # Due to cyclic dependencies, this can’t be imported at the module
-            # level.
-            from slixmpp.stanza.stream_error import StreamError
-            error = StreamError()
-            error['condition'] = 'not-well-formed'
-            error['text'] = 'Server sent: %r' % data
-            self.send(error)
-            self.disconnect()
+        for event, xml in self.parser.read_events():
+            if event == 'start':
+                if self.xml_depth == 0:
+                    # We have received the start of the root element.
+                    self.xml_root = xml
+                    log.debug('RECV: %s', highlight(tostring(self.xml_root, xmlns=self.default_ns,
+                                                         stream=self,
+                                                         top_level=True,
+                                                         open_only=True)))
+                    self.start_stream_handler(self.xml_root)
+                self.xml_depth += 1
+            if event == 'end':
+                self.xml_depth -= 1
+                if self.xml_depth == 0:
+                    # The stream's root element has closed,
+                    # terminating the stream.
+                    log.debug("End of stream received")
+                    self.abort()
+                elif self.xml_depth == 1:
+                    # A stanza is an XML element that is a direct child of
+                    # the root element, hence the check of depth == 1
+                    self._spawn_event(xml)
+                    if self.xml_root is not None:
+                        # Keep the root element empty of children to
+                        # save on memory use.
+                        self.xml_root.clear()
 
     def is_connected(self):
         return self.transport is not None

tests/test_stanza_xep_0380.py

@@ -1,37 +0,0 @@
-import unittest
-from slixmpp import Message
-from slixmpp.test import SlixTest
-import slixmpp.plugins.xep_0380 as xep_0380
-from slixmpp.xmlstream import register_stanza_plugin
-
-
-class TestEME(SlixTest):
-
-    def setUp(self):
-        register_stanza_plugin(Message, xep_0380.stanza.Encryption)
-
-    def testCreateEME(self):
-        """Testing creating EME."""
-
-        xmlstring = """
-          <message>
-            <encryption xmlns="urn:xmpp:eme:0" namespace="%s"%s />
-          </message>
-        """
-
-        msg = self.Message()
-        self.check(msg, "<message />")
-
-        msg['eme']['namespace'] = 'urn:xmpp:otr:0'
-        self.check(msg, xmlstring % ('urn:xmpp:otr:0', ''))
-
-        msg['eme']['namespace'] = 'urn:xmpp:openpgp:0'
-        self.check(msg, xmlstring % ('urn:xmpp:openpgp:0', ''))
-
-        msg['eme']['name'] = 'OX'
-        self.check(msg, xmlstring % ('urn:xmpp:openpgp:0', ' name="OX"'))
-
-        del msg['eme']
-        self.check(msg, "<message />")
-
-suite = unittest.TestLoader().loadTestsFromTestCase(TestEME)