lug/matterbridge
10
0
Fork 2
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove fallback text from XMPP replies #8

New Issue
Closed
opened 2025-11-03 20:07:26 -08:00 by jshiffer · 1 comment
jshiffer commented 2025-11-03 20:07:26 -08:00
Owner
Copy Link

XMPP replies nowadays have a reply stanza referring back to the ID of the replied-to message, but for redundancy and backwards compatibility they also directly quote the OP's message inside their body. The client is responsible for removing this redundancy when they display the message. The problem is, when XMPP replies get sent through Matterbridge, this is not accounted for -- we were the first ones to add proper reply support, anyhow. So we should get rid of the duplicate quote.
image.png

XMPP replies nowadays have a reply stanza referring back to the ID of the replied-to message, but for redundancy and backwards compatibility they also directly quote the OP's message inside their body. The client is responsible for removing this redundancy when they display the message. The problem is, when XMPP replies get sent through Matterbridge, this is not accounted for -- we were the first ones to add proper reply support, anyhow. So we should get rid of the duplicate quote. <img width="239" alt="image.png" src="attachments/91cefb89-ee41-4f03-95c1-1dcb987a1381">
image.png
17 KiB
jshiffer commented 2025-11-03 23:18:07 -08:00
Author
Owner
Copy Link

Closed by 4b0a87c3f2.

Closed by https://git.linux.ucla.edu/lug/matterbridge/commit/4b0a87c3f2cdd09e47517edb735668692e61e44d.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ahjc board eaceves ethan jshiffer mmitterberger mrisley mstf notpauleggert
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lug/matterbridge#8
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?