From 31e2edf0893b35c6c3582db28e36733cffc74c81 Mon Sep 17 00:00:00 2001 From: Patrick Connolly Date: Tue, 20 Nov 2018 21:14:56 +0800 Subject: [PATCH] Review: Using testify. Renamed var. --- bridge/slack/helpers_test.go | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/bridge/slack/helpers_test.go b/bridge/slack/helpers_test.go index bca4860b..b4b4c7be 100644 --- a/bridge/slack/helpers_test.go +++ b/bridge/slack/helpers_test.go @@ -2,13 +2,15 @@ package bslack import ( "testing" + + "github.com/stretchr/testify/assert" ) func TestExtractTopicOrPurpose(t *testing.T) { - tables := []struct{ + testcases := []struct{ input string - changeType string - output string + wantChangeType string + wantOutput string }{ {"@someone set channel topic: one liner", "topic", "one liner"}, {"@someone set channel purpose: one liner", "purpose", "one liner"}, @@ -17,10 +19,10 @@ func TestExtractTopicOrPurpose(t *testing.T) { {"some unmatched message", "unknown", ""}, } - for _, table := range tables { - changeType, output := extractTopicOrPurpose(table.input) - if changeType != table.changeType || output != table.output { - t.Error() - } + for _, tc := range testcases { + gotChangeType, gotOutput := extractTopicOrPurpose(tc.input) + + assert.Equal(t, tc.wantChangeType , gotChangeType) + assert.Equal(t, tc.wantOutput , gotOutput) } }