From 25dc18518e0873c87a917be2ea104433f82c769f Mon Sep 17 00:00:00 2001 From: Patrick Connolly Date: Tue, 23 Oct 2018 19:10:32 +0800 Subject: [PATCH] Fixed pointer/reference issue in populateUsers. [#536] --- bridge/slack/helpers.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bridge/slack/helpers.go b/bridge/slack/helpers.go index 18dded3b..6226544a 100644 --- a/bridge/slack/helpers.go +++ b/bridge/slack/helpers.go @@ -65,8 +65,11 @@ func (b *Bslack) populateUsers() { } newUsers := map[string]*slack.User{} - for _, user := range users { - newUsers[user.ID] = &user + for i, _ := range users { + // Use array index for pointer, not the copy + // See: https://stackoverflow.com/a/29498133/504018 + u := &users[i] + newUsers[u.ID] = u } b.usersMutex.Lock()