From bf7952d9c7d1cd7f676cfecb70ba2dbbb0d4c4a5 Mon Sep 17 00:00:00 2001 From: Samantaz Fox Date: Sun, 21 Nov 2021 01:46:35 +0100 Subject: [PATCH] i18n: log a warning instead of rising an exception This is more user-friendly. TODO: maybe make a compile time flag for testing purposes --- src/invidious/helpers/i18n.cr | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/invidious/helpers/i18n.cr b/src/invidious/helpers/i18n.cr index 10622517..ab959c13 100644 --- a/src/invidious/helpers/i18n.cr +++ b/src/invidious/helpers/i18n.cr @@ -65,8 +65,10 @@ def load_all_locales end def translate(locale : String?, key : String, text : String | Nil = nil) : String - # Raise an eception if "key" doesn't exist in en-US locale - raise "Invalid translation key \"#{key}\"" unless LOCALES["en-US"].has_key?(key) + # Log a warning if "key" doesn't exist in en-US locale + if !LOCALES["en-US"].has_key?(key) + LOGGER.warn("i18n: Missing translation key \"#{key}\"") + end # Default to english, whenever the locale doesn't exist, # or the key requested has not been translated