Break reference cycle to fix potential memory leaks for callback handlers.

2011-10-08 17:31:30 -04:00
parent ccbef6b696
commit 335dc2927b
3 changed files with 10 additions and 4 deletions
--- a/sleekxmpp/xmlstream/handler/waiter.py
+++ b/sleekxmpp/xmlstream/handler/waiter.py
@@ -85,14 +85,14 @@ class Waiter(BaseHandler):
                       value sleekxmpp.xmlstream.RESPONSE_TIMEOUT.
        """
        if timeout is None:
-            timeout = self.stream.response_timeout
+            timeout = self.stream().response_timeout

        try:
            stanza = self._payload.get(True, timeout)
        except queue.Empty:
            stanza = False
            log.warning("Timed out waiting for %s" % self.name)
-        self.stream.removeHandler(self.name)
+        self.stream().remove_handler(self.name)
        return stanza

    def check_delete(self):