previously, the code assumed each file had a Data, and crashed if this was not present.
now, we detect this condition, and send the URL instead.
the discord client will display URLs in a message of their own
as inline embeds, without any special behavior needed on our part.
this commit makes the same changes to the webhook and non-webhook code.
previously, the urls were just appended to the message content.
i couldn't find any other assignments directly to Extra["file"]
anywhere in the codebase, so maybe there's a better way to do this.
CTCP commands other than ACTION are designed for client-to-client interaction on
IRC networks. Drop such messages when we receive them.
Also get rid of a "CTCP_ACTION" handler in the handler registration.
This
1) can't do anything (if anything, we wanted the string constant
girc.CTCP_ACTION, which is "ACTION")
2) doesn't do anything in this context, because CTCP handlers are
registered separately:
f47717952b/ctcp.go (L205)
The PRIVMSG handler already listens to all CTCPs.
Thanks to @lexande for the bug report (found on a live instance).
Clear IRC event handlers that we will be registering for the new
connection before registering new handlers. This prevents duplicate
event handlers in the case where we are connecting via a BNC and are
seeing a reconnect. Attempting to clear handlers when none have been set
is a no-op.
Fixes 42wim#1564
Co-authored-by: Andreas Vögele <andreas@andreasvoegele.com>
Topics are surfaced by appending /<topic-id> to the channel setting for the gateway.
An example for the topic with ID of 16 would be:
```
[[gateway.inout]]
account="telegram.mytelegram"
channel="-100xxxxxxxxxx/16"
```
* Rename .{jfif,jpe} to .jpg (mumble)
* Fix messages not sending in properly if no limit is set (mumble)
Co-authored-by: yellows111 <ice_ice@email.com>
* Formatting fix (mumble)
---------
Co-authored-by: yellows111 <ice_ice@email.com>
This comes in handy for annoucement type channels where neither the SenderChat or From structs contain name information.
Also Tweak username logic as when using a full name the username field can be " " instead of "".
* Handle Whatsapp threading/replies.
In this change we are updating whatsapp message IDs to include sender JID as this is necessary to reply to a message
https://github.com/tulir/whatsmeow/issues/88#issuecomment-1093195237https://github.com/tulir/whatsmeow/discussions/148#discussioncomment-3094325
Based on commit 6afa93e537 from #1934
Author: Iiro Laiho <iiro.laiho@iki.fi>
* Fix replies.
Sender JID can have a `:` inside of it, using `/` as a delimiter now.
Added messageID parser + struct.
messages sent with an attachment do not show replies
But at least common `sendMessage` will make repies from whatsapp to an attachement bridge across.
The new message ID format broke message deleting, so we change the messageID into the real id at the beginning of send.
We really do need the extra info for when we reply to a message though.
* Refactored message replies.
file/Image/audio/replies all work now.
* Apply patch to work around the "Someone" nickname problem
* Code cleanup (whatsapp)
* Cleanup
* Code cleanup (whatsapp)
* Re-examine if sender exists
* Cleanup (whatsapp)
* Allow substitution of bot's nick in RunCommands
* Tweak description of "{BOTNICK}"
Made the description of "{BOTNICK}" consistent with that of other keywords
